feat(checks): oci-incompatible-version, for a version that cannot be an OCI tag #23
No reviewers
Labels
No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
actions/changelog!23
Loading…
Reference in a new issue
No description provided.
Delete branch "mikluko/octant/1724-semver-compliance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Octant: T1725. This is #22's content, which did not reach
main.#22 was stacked on
mikluko/octant/1724-semver-complianceand merged into that branch rather than intomain— the same way #17 merged into #14's branch earlier. #21 had already landed the compliance section, so the branch was left 2 commits ahead ofmaincarryingoci-incompatible-versionand nobody tracking it.maincurrently has 17 checks; this makes it 18.The change itself is unchanged from #22, which was reviewed and green. Repeating the substance:
Build metadata is valid Semantic Versioning and cannot be an OCI tag. The specification permits
1.2.3+build.1; the OCI tag grammar is[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}, which has no+. Git ref syntax does permit it, so such a version cuts a tag and is then not a name a registry takes.It implements the grammar rather than the one case, so the 128-character bound is checked too — a pre-release run has no bound in SemVer. The finding names the character or the length at fault.
The first check whose subject is outside the document, and the register's description says so. A repository that publishes no image or chart switches it off in
off:, and there is a test pinning that escape hatch because theerrordefault leans on it.Default confirmed as
errorby the human, which is what the ticket asked for rather than defaulted to.